Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1alpha2 MPIJob controller #98

Merged
merged 7 commits into from
May 2, 2019
Merged

Add v1alpha2 MPIJob controller #98

merged 7 commits into from
May 2, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Mar 24, 2019 •
edited by jlewi
Loading

This is the new MPIJob controller based on the API design in #95. Still a work-in-progress but creating a PR here for any immediate feedback.

Note that I created a new folder named "controllers" that includes both v1alpha1 and v1alpha2 MPIJob controllers.

This change is Reviewable

@gaocegege
Copy link
Member

Feel free to @ me when the PR is ready to review.

@terrytangyuan terrytangyuan changed the title [WIP] v1alpha2 MPIJob controller Add v1alpha2 MPIJob controller Apr 26, 2019
@terrytangyuan terrytangyuan marked this pull request as ready for review April 26, 2019 13:25
@terrytangyuan
Copy link
Member Author

terrytangyuan commented Apr 26, 2019 •
edited
Loading

This PR is now ready for review.

Note that this controller is not completely finished yet as some tests are still failing but I do not have dedicated time for this anytime soon. I see continuous contributions from the community to v1alpha1 controller but eventually require more work to land in v1alpha2 controller so I want to wrap up this PR quickly so new contributions could land in new version of the controller going forward (avoid long-running branch). The community is welcome to help fixing the tests and I will certainly look into more if I have time.

This is based on an older version ever since #95 so there are some changes that are not in this new controller yet (which could be some follow-up work by the community but keeping them here for reference later): #106 #105 #100.

/cc @gaocegege @rongou @madhukarkm @Nivedita-V

@k8s-ci-robot k8s-ci-robot requested a review from rongou April 26, 2019 13:47
@kubeflow kubeflow deleted a comment from k8s-ci-robot Apr 26, 2019
rongou
rongou requested changes Apr 26, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@rongou
Copy link
Member

rongou commented Apr 30, 2019

/lgtm

gaocegege
gaocegege reviewed May 2, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@terrytangyuan
Copy link
Member Author

Thanks everyone!
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a48fd69 into kubeflow:master May 2, 2019
@terrytangyuan terrytangyuan deleted the v1alpha2-controller branch May 2, 2019 02:06
@fisherxu fisherxu mentioned this pull request May 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@gaocegege gaocegege gaocegege left review comments

@rongou rongou rongou requested changes

@everpeace everpeace Awaiting requested review from everpeace

Assignees

@rongou rongou

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terrytangyuan @gaocegege @rongou @k8s-ci-robot @fisherxu